[EXPORTER and SDK] Additional fixes after NOMINMAX removal on Windows #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owent
approved these changes
Jan 3, 2024
ThomsonTan
approved these changes
Jan 3, 2024
meastp
force-pushed
the
meastp-fix-nominmax
branch
from
052d266 to
f02636d
Compare
|
I modified my email, CLA is signed. Should be ready to merge :) Thanks, @ThomsonTan @lalitb @owent |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2475 +/- ##
==========================================
+ Coverage 87.04% 87.06% +0.02%
==========================================
Files 199 199
Lines 6087 6087
==========================================
+ Hits 5298 5299 +1
+ Misses 789 788 -1 |
Merged
3 tasks
waywardmonkeys
added a commit
to waywardmonkeys/vcpkg
that referenced
this pull request
Jan 4, 2024
The patch to add a dependency of opentelemetry-proto on gRPC should not be needed after the upstream changes in: open-telemetry/opentelemetry-cpp#2268 Additionally, the "zpages" feature is removed as it is no longer present upstream after having been deprecated in a previous release. A patch is added extracted from open-telemetry/opentelemetry-cpp#2475 which fixes problems that arose after `NOMINMAX` was no longer defined within opentelemetry-cpp on Windows. Fixes microsoft#35992.
waywardmonkeys
added a commit
to waywardmonkeys/vcpkg
that referenced
this pull request
Jan 4, 2024
The patch to add a dependency of opentelemetry-proto on gRPC should not be needed after the upstream changes in: open-telemetry/opentelemetry-cpp#2268 Additionally, the "zpages" feature is removed as it is no longer present upstream after having been deprecated in a previous release. A patch is added extracted from open-telemetry/opentelemetry-cpp#2475 and open-telemetry/opentelemetry-cpp#2449 which fix problems that arose after `NOMINMAX` was no longer defined within opentelemetry-cpp on Windows. Fixes microsoft#35992.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes build failures after removal of NOMINMAX - previous commits from @ThomsonTan didn't have full coverage.